Make the position and the size of FileSystem controls more precise#105560
Make the position and the size of FileSystem controls more precise#105560akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Still happening: godot.windows.editor.dev.x86_64_kngFhWX8HU.mp4The code uses real image size for some reason. |
BrotherShort
force-pushed
the
Make-controls-more-precise
branch
from
3cba7a5 to
a386c85
Compare
Fixed. |
|
@KoBeWi |
|
There isn't. Looks like some conflicts were created, needs rebase. |
BrotherShort
force-pushed
the
Make-controls-more-precise
branch
2 times, most recently
from
87bd971 to
cab2993
Compare
Done. |
|
Some problems with trimming caused by this PR: |
BrotherShort
force-pushed
the
Make-controls-more-precise
branch
from
cab2993 to
a52a7a4
Compare
fixed |
|
|
||
| String _atr(int p_idx, const String &p_text) const; | ||
|
|
||
| protected: |
There was a problem hiding this comment.
Making ThemeCache protected makes it impossible for inheriting classes to implement their own. Though I see why is it needed here; I guess it's something to worry about once it actually becomes a problem (unlikely).
|
Thanks! |
3 participants
Before: The rename LineEdit is too long.
After:
Before: Text is out of hightlight backgroud.
After:
Before: The rename LineEdit covers the icon.
After:
Before: When right-to-left, The rename LineEdit and tag icons are offset.
After:
